Fix init_value and end_value in cosine decay#884
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Fix init_value and end_value in cosine decay#884copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_619109148
branch
from
b740048 to
4d720fa
Compare
Problem: * the starting value was not always init_value * the last value was not always end_value Solution: * changed the formulas (they are now compatible with the pytorch implementation https://pytorch.org/docs/stable/generated/torch.optim.lr_scheduler.CosineAnnealingLR.html) * added test to check that starting and end value coincide with `init_value` and `end_value` respectively Misc: renamed alpha -> end_value in warmup_cosine_decay_schedule PiperOrigin-RevId: 619109148
copybara-service
Bot
force-pushed
the
test_619109148
branch
from
4d720fa to
cb6cef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix init_value and end_value in cosine decay
Problem:
Solution:
init_valueandend_valuerespectivelyMisc:
renamed alpha -> end_value in warmup_cosine_decay_schedule